Add performance-optimized example for llama2 70b LoRA #12055
+561
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ludes te's fp8_model_init and torch no_grad, update TE overlap configs to allow atomic gemm + empty entries Signed-off-by: Valerie Sarge <vsarge@nvidia.com>
Signed-off-by: Valerie Sarge <vsarge@nvidia.com>
vysarge
force-pushed
the
vsarge/lora_recipe_perf
branch
from
b01cbc9 to
3b9525a
Compare
Signed-off-by: vysarge <vysarge@users.noreply.github.com>
erhoo82
reviewed
Feb 5, 2025
Comment on lines
+250
to
+252
| self.tp_comm_overlap_cfg = { | ||
| key: value for key, value in self.tp_comm_overlap_cfg.items() if value is not None | ||
| } |
There was a problem hiding this comment.
Do we need to have this given row 249?
Comment on lines
+271
to
+281
| "LORA_A2A": "1", | ||
| "CUDA_DEVICE_MAX_CONNECTIONS": "1", | ||
| "CUBLAS_FORCE_XMMA_KERNEL_INIT": "DEVICE", | ||
| "CUDNN_FRONTEND_ATTN_DP_WORKSPACE_LIMIT": "0", | ||
| "NVTE_FP8_DPA_BWD": "1", | ||
| "NVTE_RS_STRIDED_ATOMIC": "2", | ||
| "NCCL_MIN_CTAS": "32", | ||
| "NCCL_MIN_P2P_NCHANNELS": "32", | ||
| "NCCL_NCHANNELS_PER_NET_PEER": "32", | ||
| "NCCL_NVLS_ENABLE": "0", | ||
| "TORCH_NCCL_AVOID_RECORD_STREAMS": "1", |
There was a problem hiding this comment.
Can you add description on the env vars?
Please refer this PR.
#11991
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR adds an example script for llama2 70b LoRA tuning (tp4pp1cp1 on H100) including optimized configs used in MLPerf 4.1 submission, plus supporting changes.
Collection: llm
Changelog
scripts/llm/performance/mlperf_lora_llama2_70b.pyUsage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information